PixarAnimationStudios / OpenUSD

Universal Scene Description
http://www.openusd.org
Other
5.98k stars 1.18k forks source link

usdview: `time` and `frame` MaterialX Application Nodes don't work #3178

Open hybridherbst opened 1 month ago

hybridherbst commented 1 month ago

Description of Issue

MaterialX has time and frame nodes: https://github.com/AcademySoftwareFoundation/MaterialX/blob/main/documents/Specification/MaterialX.Specification.md#application-nodes

However, it looks like usdview does not set time and frame values, or I can't figure out how. They're shown as "ND_time_float" and "ND_frame_float" in usdview.

Steps to Reproduce

  1. Download and unpack TimeAndFrameNodesUSDMaterialX.zip
  2. Open in usdview
  3. Scrub the timeline
  4. Select "root/Root" and switch between material variants; "FrameSample", "TimeSample" and "MarbleTime" should to the best of my understanding animate something when the timeline is scrubbed. "Plastic" is provided for reference.

The test files come from the MaterialX repo: https://github.com/AcademySoftwareFoundation/MaterialX/blob/main/resources/Materials/TestSuite/stdlib/application/time_frame.mtlx

hybridherbst commented 1 month ago

Edit: Some applications show the "MarbleTime" node as not properly connected, but this one should be (and exhibits the same issue): myFile2.mtlx.zip

jesschimein commented 1 month ago

Filed as internal issue #USD-9894