PixarAnimationStudios / OpenUSD

Universal Scene Description
http://www.openusd.org
Other
6.13k stars 1.22k forks source link

Some Vulkan shader codegen tests fail #3276

Open DDoS opened 2 months ago

DDoS commented 2 months ago

I get this error diff for testHdStCodeGen_Vulkan_Curves_Bindless and testHdStCodeGen_Vulkan_Curves_Indirect.

2633a2634,2635
>     color.rgb = ApplyColorOverrides(color).rgb;
> 
2642c2644,2646
<     color = ShadingTerminal(vec4(Peye, 1), Neye, color, patchCoord);
---
>     color.rgb = mix(color.rgb,
>                     ShadingTerminal(vec4(Peye, 1), Neye, color, patchCoord).rgb,
>                     GetLightingBlendAmount());

I cannot find the original glslfx for the baseline code. The output shader is annotated with // line 1176 "basisCurves.glslfx", which looks like the output shader, not the baseline. I searched the code base for any other occurrence and found nothing. Either the baseline is wrong, or I'm not understanding something about the shader codegen.

Ran using Lavapipe on macOS.

jesschimein commented 2 months ago

Filed as internal issue #USD-10088