PixarAnimationStudios / OpenUSD

Universal Scene Description
http://www.openusd.org
Other
6.18k stars 1.23k forks source link

Autodesk: Fix leaking Vulkan buffer from HdSt_PipelineDrawBatch #3313

Closed erikaharrison-adsk closed 1 month ago

erikaharrison-adsk commented 2 months ago

Description of Change(s)

This went undetected by the validation layer because the tests were also leaking the Vulkan instance and device, so they were never destroyed, and the validation check never kicked in. So fix the leaking tests too.

This also fixes an occasional crash from a driver trying to use a resource after the tests had exited main(), because the HgiVulkan leak also meant no synchronization.

Added some more buffer naming to help debug the leak and included it in the PR as it's useful for debugging.

Fixes Issue(s)

jesschimein commented 2 months ago

Filed as internal issue #USD-10181

jesschimein commented 2 months ago

/AzurePipelines run

azure-pipelines[bot] commented 2 months ago
Azure Pipelines successfully started running 1 pipeline(s).