Move all the Windows dll path logic into the WindowsImportWrapper - Githubissues

PixarAnimationStudios / OpenUSD

Universal Scene Description

http://www.openusd.org

Other

6.17k stars 1.23k forks source link

Move all the Windows dll path logic into the WindowsImportWrapper #3353

Open tbttfox opened 1 month ago

tbttfox commented 1 month ago

Description of Change(s)

There's already a python context in pxr/tf/__init__.py that handles adding and removing dll paths for windows, so I moved the Windows specific import path logic out of the pxr/__init__.py to there. This way, we don't have to permanently change the PATH

I couldn't get the tests to pass locally from the dev build, even without my changes. And I couldn't get the release branch to build because boost breaks. Any suggestions how to deal with this?

However, I was able to test that my changes load the correct DLL's on python 3.7, python 3.11, and anaconda 3.12 both with and without the PXR_USD_WINDOWS_DLL_PATH variable set. (I just copied my changes directly into different pip installs)

Fixes Issue(s)

https://github.com/PixarAnimationStudios/OpenUSD/issues/3114

[ ] I have verified that all unit tests pass with the proposed changes
[x] I have submitted a signed Contributor License Agreement

jesschimein commented 1 month ago

Filed as internal issue #USD-10276

:heavy_exclamation_mark: Please make sure that a signed CLA has been submitted!

jesschimein commented 1 month ago

/AzurePipelines run

azure-pipelines[bot] commented 1 month ago

Azure Pipelines successfully started running 2 pipeline(s).

dgovil commented 2 weeks ago

@sunyab does USD still support Python 3.7 ? If not then perhaps the version check here could be simplified and moved to a build time check for 3.8+?

jesschimein commented 2 weeks ago

/AzurePipelines run

azure-pipelines[bot] commented 2 weeks ago

Azure Pipelines successfully started running 2 pipeline(s).