PixarAnimationStudios / OpenUSD

Universal Scene Description
http://www.openusd.org
Other
6.17k stars 1.23k forks source link

Autodesk: Vulkan Bugfix - HgiVulkanBlitCmds offset #3382

Closed erikaharrison-adsk closed 1 week ago

erikaharrison-adsk commented 4 weeks ago

Description of Change(s)

⚠️ Branched off feature-hgi-vulkan.

The staged copy of HgiVulkanBlitCmds has incorrect source and destination offset,

Source offset of a cpu-to-gpu-copy defines the offset of the source cpu memory, and the destination offset of a cpu-to-gpu-copy defines the offset of the destination gpu buffer.

The memcpy from the cpu memory to the staging buffer should use the source offset and the destination offset respectively. But the copy from the staging buffer to the gpu buffer should use the destination offset to define VkBufferCopy.srcOffset.

Link to proposal (if applicable)

N/A

Fixes Issue(s)

N/A

Checklist

[ ] I have created this PR based on the dev branch

[X] I have followed the coding conventions

[ ] I have added unit tests that exercise this functionality (Reference: testing guidelines)

[X] I have verified that all unit tests pass with the proposed changes

[X] I have submitted a signed Contributor License Agreement (Reference: Contributor License Agreement instructions)

jesschimein commented 3 weeks ago

Filed as internal issue #USD-10365

jesschimein commented 3 weeks ago

/AzurePipelines run

azure-pipelines[bot] commented 3 weeks ago
Azure Pipelines successfully started running 1 pipeline(s).