PixarAnimationStudios / OpenUSD

Universal Scene Description
http://www.openusd.org
Other
6.17k stars 1.23k forks source link

work: account for task_group_base interface change in oneTBB 2022.0.0 #3392

Open mattyjams opened 3 weeks ago

mattyjams commented 3 weeks ago

The m_wait_ctx member being used in a narrow band of oneTBB versions was removed in a refactor that went into version v2022.0.0 which was released yesterday: https://github.com/oneapi-src/oneTBB/commit/1f52f5093ec7ce23829fe64ab82ac5541fea42ee

This change accounts for the update in the new version of oneTBB and uses the newly added m_wait_vertex member to access the same context as before.

I am far from an expert in the TBB API or the intricacies of this area of libwork, but wanted to offer this up as it allowed me to successfully build OpenUSD against the latest version of oneTBB. I have not done any performance profiling with the new oneTBB version.

Checklist

[x] I have created this PR based on the dev branch

[x] I have followed the coding conventions

[ ] I have added unit tests that exercise this functionality (Reference: testing guidelines)

[x] I have verified that all unit tests pass with the proposed changes

[x] I have submitted a signed Contributor License Agreement (Reference: Contributor License Agreement instructions)

jesschimein commented 3 weeks ago

Filed as internal issue #USD-10388

jesschimein commented 3 weeks ago

/AzurePipelines run

azure-pipelines[bot] commented 3 weeks ago
Azure Pipelines successfully started running 1 pipeline(s).