Pixate / pixate-freestyle-ios

Pixate Freestyle for iOS
Apache License 2.0
849 stars 134 forks source link

Assertions crashes #152

Closed vguerci closed 3 years ago

vguerci commented 10 years ago

Had some crashes with an app built on iOS7.1 when running on iOS8. Looks like that UITableViewHeaderFooterView inner workings has changed in iOS8 (see #148), which resulted in assertions errors in NSObject+PXSubclass.m:63 :

if (![object isKindOfClass:[self superclass]]) {
    NSAssert(NO, @"Class %@ doesn't fit for subclassing.", [superClass description]);
    return;
}

Assertions = Exceptions = Crash if uncaught. A common practice in iOS/OSX development is simply to disable assertions at release, in order to avoid such crashes.

Just adding OTHER_CFLAGS = "-DNS_BLOCK_ASSERTIONS=1"; to the Release configuration and generating the framework using ./scripts/build_framework.sh -c Release solves these potentials unwanted assertions crashs.

pentateu commented 10 years ago

I just had the same issue..

I have also disabled the assertions.. is there any reason NSAssert was used here instead of a simple NSLog()?

andreacremaschi commented 9 years ago

up

java13 commented 9 years ago

I just had the same issue..but working with Xamarin... any idea?

Zbeyer commented 7 years ago

I know it's been 2+ years, but did anyone find a fix?

anton-matosov commented 7 years ago

Freestyle is officially dead. I have a project that is based on this one that includes fixes for the latest iOS https://github.com/StylingKit/StylingKit

vinothbtechit commented 7 years ago

@anton-matosov - Pixate freestyle crashes on ios 11 beta 10, Can i use https://github.com/StylingKit/StylingKit ? without code level changes ?

anton-matosov commented 7 years ago

iOS 11 crash fix is available in the branch feature/PhotoUICompat, not released yet use pod "StylingKit", :git => "https://github.com/StylingKit/StylingKit.git", :branch => "feature/PhotoUICompat" to install

anton-matosov commented 7 years ago

I will try to release it as hotfix sometime soon

vinothbtechit commented 7 years ago

Thank you.

On Mon, Sep 11, 2017 at 4:07 AM, Anton Matosov notifications@github.com wrote:

I will try to release it as hotfix sometime soon

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Pixate/pixate-freestyle-ios/issues/152#issuecomment-328377154, or mute the thread https://github.com/notifications/unsubscribe-auth/AFbRvj3mDjRjev4cJbq8Oq3O9aYQt_txks5shGSngaJpZM4CoRhb .

-- Regards, Vinoth Arunagiri, +91-805-618-8894

anton-matosov commented 7 years ago

You are welcome.

Please feel free to reach me out Either on StylingKit issues page https://github.com/StylingKit/StylingKit/issues Or via StylingKit Slack https://stylingkit-slackin.herokuapp.com/

vinothbtechit commented 6 years ago

Hi Anton,

Still the branch feature/PhotoUICompat available ?

On Mon, Sep 11, 2017 at 4:06 AM, Anton Matosov notifications@github.com wrote:

iOS 11 crash fix is available in the branch feature/PhotoUICompat, not released yet use pod "StylingKit", :git => "https://github.com/ StylingKit/StylingKit.git", :branch => "feature/PhotoUICompat" to install

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Pixate/pixate-freestyle-ios/issues/152#issuecomment-328377123, or mute the thread https://github.com/notifications/unsubscribe-auth/AFbRvtOHjWyY8f3rMBq9GbB1DpV0tv64ks5shGR8gaJpZM4CoRhb .

-- Regards, Vinoth Arunagiri, +91-805-618-8894

anton-matosov commented 6 years ago

Hi @vinothbtechit This fix is in the latest release. No need for this branch anymore.

vinothbtechit commented 6 years ago

Hi Anton,

0.4.3 is the latest release right ?

On 01-May-2018, at 12:05 AM, Anton Matosov notifications@github.com wrote:

Hi @vinothbtechit This fix is in the latest release. No need for this branch anymore.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

anton-matosov commented 6 years ago

Correct. You can see all releases and release notes here https://github.com/StylingKit/StylingKit/releases