PixelTracksAlpaka / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
0 stars 2 forks source link

update of HLT customisation with Alpaka pixel reco #30

Closed missirol closed 1 year ago

missirol commented 1 year ago
%MSG-w SiPixelMonitorRecHitsSoAAlpaka:   SiPixelPhase1MonitorRecHitsSoAAlpaka:hltSiPixelRecHitsSoAMonitorGPU  30-Jun-2023 09:44:24 CEST Run: 368822 Event: 390960755
No RecHits SoA found
 returning!
%MSG
%MSG-w SiPixelMonitorRecHitsSoAAlpaka:   SiPixelPhase1MonitorRecHitsSoAAlpaka:hltSiPixelRecHitsSoAMonitorCPU  30-Jun-2023 09:44:24 CEST Run: 368822 Event: 390960755
No RecHits SoA found
 returning!
%MSG
missirol commented 1 year ago

%MSG-w SiPixelMonitorRecHitsSoAAlpaka: SiPixelPhase1MonitorRecHitsSoAAlpaka:hltSiPixelRecHitsSoAMonitorGPU 30-Jun-2023 09:44:24 CEST Run: 368822 Event: 390960755 No RecHits SoA found

Those warnings go away with the following change (but I did not check the DQM outputs).

diff --git a/DQM/SiPixelHeterogeneous/plugins/SiPixelMonitorRecHitsSoAAlpaka.cc b/DQM/SiPixelHeterogeneous/plugins/SiPixelMonitorRecHitsSoAAlpaka.cc
index 3906bd2e203..e63842b51e3 100644
--- a/DQM/SiPixelHeterogeneous/plugins/SiPixelMonitorRecHitsSoAAlpaka.cc
+++ b/DQM/SiPixelHeterogeneous/plugins/SiPixelMonitorRecHitsSoAAlpaka.cc
@@ -1,13 +1,3 @@
-// -*- C++ -*-
-///bookLayer
-// Package:    SiPixelMonitorRecHitsSoAAlpaka
-// Class:      SiPixelMonitorRecHitsSoAAlpaka
-//
-/**\class SiPixelMonitorRecHitsSoAAlpaka SiPixelMonitorRecHitsSoAAlpaka.cc
-*/
-//
-// Author: Suvankar Roy Chowdhury, Alessandro Rossi
-//
 #include "DataFormats/Math/interface/approx_atan2.h"
 #include "DataFormats/Common/interface/Handle.h"
 #include "FWCore/Framework/interface/Event.h"
@@ -15,13 +5,10 @@
 #include "FWCore/Framework/interface/MakerMacros.h"
 #include "FWCore/MessageLogger/interface/MessageLogger.h"
 #include "FWCore/ParameterSet/interface/ParameterSet.h"
-// DQM Histograming
 #include "DQMServices/Core/interface/MonitorElement.h"
 #include "DQMServices/Core/interface/DQMEDAnalyzer.h"
 #include "DQMServices/Core/interface/DQMStore.h"
-#include "CUDADataFormats/TrackingRecHit/interface/TrackingRecHitSoAHost.h"
-#include "CUDADataFormats/TrackingRecHit/interface/TrackingRecHitsUtilities.h"
-// Geometry
+#include "DataFormats/TrackingRecHitSoA/interface/TrackingRecHitSoAHost.h"
 #include "Geometry/TrackerGeometryBuilder/interface/TrackerGeometry.h"
 #include "DataFormats/TrackerCommon/interface/TrackerTopology.h"
 #include "Geometry/CommonDetUnit/interface/PixelGeomDetUnit.h"
@@ -32,8 +19,7 @@
 template <typename T>
 class SiPixelMonitorRecHitsSoAAlpaka : public DQMEDAnalyzer {
 public:
-  using HitSoA = TrackingRecHitSoAView<T>;
-  using HitsOnHost = TrackingRecHitSoAHost<T>;
+  using HitsOnHost = TrackingRecHitAlpakaHost<T>;

   explicit SiPixelMonitorRecHitsSoAAlpaka(const edm::ParameterSet&);
   ~SiPixelMonitorRecHitsSoAAlpaka() override = default;
missirol commented 1 year ago

The latest commit fixes the type of the input collection consumed by SiPixelMonitorRecHitsSoAAlpaka, plus some minor clean up.