adilanchian
commented
6 years ago Closing this as we are going to branch release-1.0.1
Closed frubesss closed 6 years ago
adilanchian
commented
6 years ago Closing this as we are going to branch release-1.0.1
[x] User can enter blank title: Fixed by trimming the inserted value and seeing if it contains any text, fairly simple.
[x] User can enter custom unchecked time. (e.g., -10, 0, 111111111111111111111111): Fixed by adding basic HTML form min and max values. The only two downsides I see to this is the form validation style now looks completely different to the style you originally created potentially causing confusion and the max value the user can insert has been restricted to 1 year, not sure how you feel about that but seems sensible in the grand scheme of things.
[x] When editing focus block title. pressing enter defaults to delete prompt. bad UX: Another simple fix, both the delete and cancel buttons did not have a type attribute causing the form to default to the first button in the form when the user pressed the enter key.
[x] When time is too great, countdown timer does not work when clicking gets focused - This has been inherently fixed via the 2nd bug I spoke about above.
Thanks