[Enhancement] Migrate to React-Navigation V5

PixelogicDev / Gruvee-Mobile

#WeAreGrüvee

MIT License

48 stars 11 forks source link

[Enhancement] Migrate to React-Navigation V5 #123

Closed adilanchian closed 4 years ago

adilanchian commented 4 years ago

Is your feature request related to a problem? Please describe. Ya. React-Native-Navigation blows and makes no sense for us to keep using. It's time to switch

Describe the solution you'd like I would like to move to React-Navigation V5 as it seems to have more support and a cleaner way of implementing navigation in React Native

Describe alternatives you've considered Spent 149 days working with React-Native-Navigation. It's just not worth it anymore

adilanchian commented 4 years ago

Ripped out the old navigation library, brought in react navigation v5 and started to hook up redux. Need to create an app container that holds navigation and redux logic.

adilanchian commented 4 years ago

What We Did Today

Setup Redux for our new navigation library
Spent the rest of the stream getting the Large Title / Navigation Stacks setup
Ran into a slight snag where the loading indicator on "pull to refresh" doesn't actual show the loading indicator

What We Will Do Next Time

[x] Finish getting our large header done
[ ] Verify the header works on header
[ ] Finish setting up/styling navigation transitions

adilanchian commented 4 years ago

What We Did Today

Setup PlaylistListView to be 90% correct with navigation
Added proper signout button for PlaylistListView

What We Will Do Next Time

[x] Verify header works properly on Android
[x] Finish styling bottomsheet to pop up properly
[ ] Continue proper navigation on other views

adilanchian commented 4 years ago

What We Did Today

Ran into a huge problem with old nav library not fully removed. But we fixed it!
Added proper signout for Firebase user
Fixed weird issue with bottomsheet pop up being covered by navbar

What We Will Do Next Time

[x] Move onto navigating to the songs list and comments list
[ ] Make final navbar changes before moving back to apple auth work

adilanchian commented 4 years ago

What We Did Today

Fixed issue with local IP address not working
Setup navigation to go to Songs List view
Start implementing side drawer navigation for songs list view (trying to pass in navigator to toggle side drawer. Has proven to be a tad difficult)

What We Will Do Next Time

[x] Continue working on getting side menu navigation working'
[x] Move onto navigating to comments list
[ ] Make final navbar changes before moving back to apple auth work

adilanchian commented 4 years ago

NOTE: https://reactnavigation.org/docs/header-buttons/#header-interaction-with-its-screen-component

adilanchian commented 4 years ago

What We Did Today

Fixed a bunch of navigation stuff
Added the members side drawer to songs list
Setup initial work for navigating to comments list

What We Will Do Next Time

[x] Clean up any final navigation things (design, ux, etc)
[x] Move back onto Apple Auth!

adilanchian commented 4 years ago

We finished this up and will be moving back to Apple Auth! Going to make a PR to go into Apple Auth branch