[Release-1.0] Design and build comments section

PixelogicDev / Gruvee-Mobile

#WeAreGrüvee

MIT License

48 stars 11 forks source link

[Release-1.0] Design and build comments section #14

Closed adilanchian closed 4 years ago

adilanchian commented 4 years ago

General

Grüvee will be utilizing commenting per song. This is outlined in the MVP and has designs setup for it. Currently there are sketch designs that have been created. This issue is to finalize the design and develop the ui/ux for Android and iOS.

Tasks

[x] Finalize UI/UX in Sketch
[x] Generate a component that can handle the comments
[x] Setup an action to open and close comments section and/or pop an overlay for comments
[x] Verify design is functional on both Android and iOS

Screenshots

Here are the current ideas for the comments section:

adilanchian commented 4 years ago

Spent most of today trying to deal with the height issue when adding the comments section to our songitem. A lot of things going on here, but basically we need to set the height on the SwipeRow component. This seems to have some implications for the playlist list view that we will also need to look into.

There is also potentially a bug in the SwipeRow library we are using, but with the method listed above we can get around it

adilanchian commented 4 years ago

We were able to get the component setup for the comments section and are currently working on adding the styling for the comment items themselves. We still have not finalized the design to go with haha. Will do that next stream!

adilanchian commented 4 years ago

We are having a lot of issues with nested scroll views. TL;DR can't scroll a FlatList inside another FlatList which is essentially what we have. There is a solution here: https://github.com/facebook/react-native/issues/1966

There is also another option to change how we render the comments sections. We can push out to a new view or even set an overlay. This might be the preferred option.

adilanchian commented 4 years ago

Alrighty, decided to go to a completely different view for comments. In the process of designing the flatlist view and adding in the proper actions

adilanchian commented 4 years ago

~Make sure to hide delete action if the comment was not written by you~
~Fix delete action not being fully hidden~
~Setup proper state~

adilanchian commented 4 years ago

Next things needed here are:

Add comment section
Update state for newly added comments
MAYBE add ability to like comments / ability to reply to specific comments

Working on adding the add comment component and having some flex issues. Will need to decide if we should use a hacky way of flex or just set percentage heights

adilanchian commented 4 years ago

COMMENTS ARE LIVE. Checking to make sure this works on Android is next and then we can MOVE ON.

adilanchian commented 4 years ago

WE DONE FAM.