Add apple to social platforms

[InukVT]

Adding Apple to sign in options should happen ASAP, because adding just one item can drastically change the look and feel of a view

[InukVT]

@adilanchian do we have Auth logic somewhere or are the buttons just there to look pretty for now?

[adilanchian]

Hey dude! So this is great, but just want to clarify that this will be for Apple Music not Apple auth in general. We should figure out a way to properly utilize Apple's Apple Music API as well

@adilanchian do we have Auth logic somewhere or are the buttons just there to look pretty for now? No logic currently. Just pretty buttons :)

[InukVT]

Thing is, Sign in With Apple is required if you have any oAuth happenings in the app, otherwise the app’ll get rejected in app review

On 28 Jan 2020, at 14.35, Alec Dilanchian notifications@github.com wrote:

Hey dude! So this is great, but just want to clarify that this will be for Apple Music not Apple auth in general. We should figure out a way to properly utilize Apple's Apple Music API as well

@adilanchian https://github.com/adilanchian do we have Auth logic somewhere or are the buttons just there to look pretty for now? No logic currently. Just pretty buttons :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PixelogicDev/Gruvee/pull/27?email_source=notifications&email_token=ABWI7E6YH3XOFAWICDRGHBTRAAYBVA5CNFSM4KMNLUI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKDKAMQ#issuecomment-579248178, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWI7E3JTAHIDMKBNPFLXM3RAAYBVANCNFSM4KMNLUIQ.

[InukVT]

I can't find the Apple logo, if anyone knows anything, I'm happy to know!

[adilanchian]

ALSO -

"creativenobu: update on the apple logo, you can use the apple music logo and say "Login with Apple Music" seems like apple doesn't like it's logo on products"

[creativenull]

We can use the apple music icon from their official assets here (under the Apple Music Icon) and convert from svg to png.

[InukVT]

@creativenobu I can't find a download, mind collabing on the PR? (remember to add your name to the readme)

[adilanchian]

@BastianInuk - Actually found the download link here: https://www.apple.com/itunes/marketing-on-music/identity-guidelines.html#apple-music-icon

I believe this is the one we are looking for ya?

[creativenull]

@BastianInuk I can download the SVG, convert to PNG and do a separate PR on just the PNG file. You can do the linking in the code in this PR :grinning:

[InukVT]

OR you can do a PR on my PR? 👀

On 10 Feb 2020, at 21.32, Arnold Chand notifications@github.com wrote:

@BastianInuk https://github.com/BastianInuk I can download the SVG, convert to PNG and do a separate PR on just the PNG file. You can do the linking in the code in this PR 😀

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PixelogicDev/Gruvee/pull/27?email_source=notifications&email_token=ABWI7E3G576DH42NNWBAN5TRCG2XDA5CNFSM4KMNLUI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELKFD5Q#issuecomment-584339958, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWI7E7GF5O5DTYKJ7R5Y3TRCG2XDANCNFSM4KMNLUIQ.

[adilanchian]

Hey @BastianInuk & @creativenobu - I am not sure what "doing a PR on my PR" means haha. BUT either way, @BastianInuk can you remove the old asset and merge your change in and @creativenobu will go ahead and create a separate PR with his addition to the README and new asset?

I think this will be easiest for all :). Thanks!

[creativenull]

@adilanchian I've added an assets only PR #32

[adilanchian]

Thank you for your contribution! I went ahead and merged this in and will be fixing the file comment :)

[isabellabrookes]

@all-contributors please add @BastianInuk for code

[allcontributors[bot]]

@isabellabrookes

I've put up a pull request to add @BastianInuk! :tada:

[isabellabrookes]

@all-contributors please add @creativenobu for code

[allcontributors[bot]]

@isabellabrookes

I've put up a pull request to add @creativenobu! :tada: