search

PixelogicDev / Gruvee-Mobile

#WeAreGrüvee
MIT License
48 stars 11 forks source link

[Bug] Delete button leaking to the main view #31

Open mustiikhalil opened 4 years ago

mustiikhalil commented 4 years ago

The delete button leaks into the view when pressing the cells. This issue happens in the following screens:

How to replicate: 1- Login 2- Press on any playlist and it would leak in the delete button 3- Press on the comments button and the bottom of the delete button will show up

https://user-images.githubusercontent.com/37905409/80289584-f77ced80-8704-11ea-85fd-7249befe5d34.gif

adilanchian commented 4 years ago

@mustiikhalil thanks so much for the issue! I have tagged this and wanted to add bit more insight on this for anyone who may want to pick it up:

These cells are created by using a TouchableOpacity component. The "fade out" animation here is because of that view. We have two options from what I've seen:

  1. Change the parent view to be some other Touchable view that does not change opacity. Which would require us to create a component with our own animation on it
  2. When the cell is touched we can set the button behind to an opacity of 0 so it doesn't show it.

I personally prefer option 1 as this is a more long term fix and could give Grüvee some dope animnations!