Detect if terminal returns error and display it

[GoogleCodeExporter]

Wishlist item (and not sure if an error status is returned): it would be a good 
idea if winff would check the exit status of the call to the terminal and 
display any error that occurs, possibly even with a hint to the most likely way 
to fix it. E.g. """Conversion of the video failed. The most likely cause is 
that the setting in "Edit -> Preferences -> Linux": "Terminal Options" is 
incorrect. Try changing "-e" to "-x" or vice versa."""

What steps will reproduce the problem?
1. Install terminator as your terminal (on debian/ubuntu systems: 
/etc/alternatives/x-terminal-emulator should point to /usr/bin/terminator), but 
DON'T set the "Terminal Options" to "-x"
2. Convert any video

What is the expected output? What do you see instead?
Expect that terminal is started up and you see ffmpeg processing the file. 
Instead you see nothing happening, because terminator does not honor "-e" 
option correctly.

What version of the product are you using? On what operating system?
DistroRelease: Ubuntu 10.10
Package: winff 1.2.0-1ubuntu2
ProcEnviron:
 LANG=en_US.utf8
 SHELL=/bin/bash

Please provide any additional information below.
https://bugs.launchpad.net/ubuntu/+source/winff/+bug/687687

Original issue reported on code.google.com by poipodec...@hotmail.com on 11 Dec 2010 at 12:58

[GoogleCodeExporter]

Matt,

I created a patch to see this bug fixed. As I think this is more then fixing a 
typo, I appreciate it if you could have a look at it before I commit it.

I used an additional system call because you don't want to wait for the ffmpeg 
terminal to finish if it is really converting videos.

Original comment by poipodec...@hotmail.com on 29 May 2011 at 11:23

• Changed state: Accepted
• Added labels: Usability

Attachments:

• check_terminal.diff

[GoogleCodeExporter]

I intend to have this implemented in Winff 1.5 (I should finished this a long 
time ago).

Original comment by poipodec...@hotmail.com on 14 Jan 2012 at 8:17

• Added labels: Milestone-Release1.5

[GoogleCodeExporter]

This fix is not going into release 1.5.

Original comment by poipodec...@hotmail.com on 16 Dec 2012 at 4:29

• Added labels: Milestone-Release1.6
• Removed labels: Milestone-Release1.5

[GoogleCodeExporter]

terminator do the same thing on my system - nothing. change the settings here:
Edit=>Preferences=>Linux=>Terminal to run FFmpec in: to xterm (for example)

that work for me.

good luck.

GOD bless you

Original comment by pohl...@gmail.com on 22 Jan 2013 at 7:45

[GoogleCodeExporter]

Fixed in revision 818

Original comment by poipodec...@hotmail.com on 15 Feb 2014 at 10:25

• Changed state: Fixed