Pixelpanic / winff

Automatically exported from code.google.com/p/winff
0 stars 0 forks source link

Filenames with '&' (ampersand) character cause problems in generated batch file on windows #172

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Create/rename any video to include '&' character in file name
2. Process file with WinFF

What is the expected output? What do you see instead?
The batch file created for processing files uses the 'title' command to set the 
window title.  When the command processor executes the 'title' command the 
embedded '&' character is interpreted as a command separator and the remainder 
of the filename is executed as a new command.

What version of the product are you using? On what operating system?
WinFF v1.4.2
Windows 7 Enterprise x64

Please provide any additional information below.
File name should be surrounded with double quotes to prevent command processor 
from interpreting embedded special characters.

Original issue reported on code.google.com by EMon...@gmail.com on 8 Aug 2012 at 12:11

GoogleCodeExporter commented 8 years ago
I tested this on my Linux system and it does not present an issue there. I 
think the issue is in unit1.pas on line 1053, but as I can not test this, I am 
hesitant to fix this.

Original comment by poipodec...@hotmail.com on 21 Aug 2012 at 8:04

GoogleCodeExporter commented 8 years ago

Original comment by poipodec...@hotmail.com on 21 Aug 2012 at 8:05

GoogleCodeExporter commented 8 years ago
'&' ampersands are removed for security reasons. They could allow someone to 
embed commands.

Original comment by bgg...@gmail.com on 16 Aug 2013 at 3:44