Pixelpanic / winff

Automatically exported from code.google.com/p/winff
0 stars 0 forks source link

WinFF should check for and escape the character ". #38

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Create a video with a name which includes quote's, e.g. video_"me".avi
2. Use winff with any preset to convert.

What is the expected output? What do you see instead?
I expect the file to be converted. Instead the terminal that Winff starts
crashes before I even can see what the problem is.

Please use labels and text to provide additional information.
Winff should probably include a test for " and escape the character in the
output.

See http://ubuntuforums.org/showthread.php?p=7017499#post7017499 for a user
that had this problem. I am not sure yet if this is a general problem, or
just in Linux versions.

Original issue reported on code.google.com by poipodec...@hotmail.com on 5 Apr 2009 at 1:46

GoogleCodeExporter commented 8 years ago
Apparently other people also encounter this problem and are therefor moving 
away from
winff. They even claim that other characters are also a problem: - . , : " ; [] 
() 

See http://ubuntuforums.org/showpost.php?p=7594474&postcount=18

Original comment by poipodec...@hotmail.com on 12 Jul 2009 at 8:01

GoogleCodeExporter commented 8 years ago
Doesn't look like it affects windows as I tried to create a filename including 
quotes
which failed.  Will try and fix my test version and report back.

Original comment by istoff@gmail.com on 13 Aug 2009 at 11:19

GoogleCodeExporter commented 8 years ago
made changes to svn branch 1.5

tested with spaces & quote marks.
if this fix is stable will add more characters.

Original comment by istoff@gmail.com on 18 Aug 2009 at 8:11

GoogleCodeExporter commented 8 years ago
Added fix to the main source. Like Ian said, will add more characters as 
needed. Not 
sure will need any because The filenames are all quoted, and any characters 
inside the 
quotes shouldn't need escaping. 

Original comment by bgg...@gmail.com on 7 Jan 2010 at 12:47

GoogleCodeExporter commented 8 years ago

Original comment by bgg...@gmail.com on 7 Jan 2010 at 12:48

GoogleCodeExporter commented 8 years ago

Original comment by bgg...@gmail.com on 13 Jan 2010 at 8:30

GoogleCodeExporter commented 8 years ago
Paul's fix is good enough.

Original comment by bgg...@gmail.com on 1 Feb 2010 at 4:11