Closed GoogleCodeExporter closed 8 years ago
Lets clear that up a little bit more, what exactly are you expecting here? Are
you
experiencing the same problem as in bug 10? Or the other problem: I think that
your
font is too large (system setting) for the fields that are available. This is
also
the case in English, so not related to the non-English fields. Matt, can you
comment
on this last issue (could you make the text-fields adjustable depending on the
amount
of text that needs to go in)?
Original comment by poipodec...@hotmail.com
on 1 Jul 2009 at 8:07
>Are you experiencing the same problem as in bug 10?
no, pls see attachment. Cyrillic folder name with spaces and cyrillic file name
with
spaces.
>I think that your font is too large (system setting) for the fields that are
vailable.
14pt is it big?:) i think that no
Original comment by alero...@gmail.com
on 1 Jul 2009 at 11:03
Attachments:
Is it correct that you have a high resolution screen? If yes, how big?
My font size is 9pt and that is in Dutch also slightly to big (see my screen
shot).
But is this your problem, or are you trying to tell something different? I still
don't understand what EXACTLY you want us to look at in the first screen shot.
Original comment by poipodec...@hotmail.com
on 1 Jul 2009 at 11:19
Attachments:
>But is this your problem, or are you trying to tell something different?
in the first screenshot i try to figure, that text in the application buttons
is out
of border.
i don't know who is wrong: my system settings, mistakes in winff or GTK lib.
But the
Gimp, for example, in my box has no problems like this.
Original comment by alero...@gmail.com
on 1 Jul 2009 at 11:33
Ok, what I know this is a problem that Matt has to solve and is not YOUR
mistake.
I changed the summary of this bug.
Original comment by poipodec...@hotmail.com
on 1 Jul 2009 at 11:39
ok, thank you!
Original comment by alero...@gmail.com
on 1 Jul 2009 at 11:46
Just like before. The text labels are automatic depending on the size of the
string.
I use the DEFAULT font and the DEFAULT size. I set all the text label options to
default and autoamatic. Fonts and their sizes vary between linux distributions,
let
alone mswindows.
If i set the fonts and size to anything else, it screws up a lot of other
systems.
Original comment by bgg...@gmail.com
on 20 Jul 2009 at 3:46
Matt,
What I don't understand is why WinFF can not adjust the space for text during
rendering on the users machine depending on the size needed for the string,
which in
turn depends on the font, font size and the translation. Other programs seem
very
well able to do this. I don't know fpc enough to comment on this myself, but if
this
is not able (yet) than I think we should file a wish-list bug in the fpc bug
tracker
for this. Screens are getting very high resolutions nowadays, and just to be
able to
read the text under a button one might need to set the DEFAULT font size on
his/her
system to something which you might consider huge on an low-res monitor.
Just my 2 cents.
Original comment by poipodec...@hotmail.com
on 20 Jul 2009 at 4:45
The button captions aren't always right in english either, actually most of the
time
they are not. It is not as simple as just setting autosize to true. You must
also set
all the controls to autosize in a parent/child/grandchildren/... relationship.
AND
Then those relationships will be different for different widget sets. AND Then
they
will be different for different default fonts and sizes across different
platforms
and distributions. AND Then there is lazarus bugs in all of those things. And
then
they all would have to change every time we add anything to the interface.
That's why we spaced out the options with just a few on a tab, to create more
space
for labels in the interface. It is still a problem in the buttons. Even the
english
doesn't fully fit in most linux's
Original comment by bgg...@gmail.com
on 2 Aug 2009 at 9:02
Issue 72 has been merged into this issue.
Original comment by poipodec...@hotmail.com
on 1 May 2010 at 11:51
Also reported in Ubuntu now.
https://bugs.launchpad.net/ubuntu/+source/winff/+bug/695040
Original comment by poipodec...@hotmail.com
on 2 Jan 2011 at 11:52
Hi there!
I've worked on this Issue a couple of days and have some positive results (see
screenshots).
Almost all controls on all forms are now autosizeable to fit translated text of
any (reasonable) length.
I also reworked a translation system, which is now uses Lazarus built-in i18n
support (autogeneration of .po files). Now there is no need to duplicate
resource strings for captions, labels and hints in .pas files, they are
translated in .lfm files automatically.
All my work is available in git:
https://github.com/lion-simba/WinFF/tree/winff-rework-translate (first commit
of it is based on revision 494 of
http://code.google.com/p/winff/source/browse/#svn%2Ftrunk%2F%20winff%20--usernam
e%20bggmtt SVN tree).
It would be great if somebody test this on different Linux and Windows machines.
Original comment by m...@alexey.osipov.name
on 7 Jan 2011 at 9:28
Attachments:
The screen shots are great. Thanks.
I leave the code check to BiggMatt thou.
@BiggMatt: are you comfortable with GIT or do you want me to create a diff.
Original comment by poipodec...@hotmail.com
on 8 Jan 2011 at 9:17
Issue 94 has been merged into this issue.
Original comment by poipodec...@hotmail.com
on 8 Jan 2011 at 9:28
Hi Simba,
In the meantime I did have a look at a selection of your changes. Although I
appreciate the progress that you made I feel uncomfortable with the fact that
you changed so much. Three things are mixed: the space for text (this bug), the
translation system AND renaming, reordering and resizing of code objects and
string (without discussing with BiggMatt first). Especially the later one (the
combination of three) makes it very hard to review your changes. I am
considering of picking parts of your fixes (at least for Debian and Ubuntu) for
now, but it may help if you could split your changes into three different sets
(I know, quite some work, but a lot better for review). (More separated commits
in git would have helped.)
Unless BiggMatt agrees to take over your changes as-is of course.
If I understand your changes correct, you needed to create several new panels
to have the text and boxes align in groups, right?
What did you need to do to get the translation system reworked? Just the
potranslator.pas file and adding the "hint:" texts to the .lfm files?
Original comment by poipodec...@hotmail.com
on 9 Jan 2011 at 12:05
Hi Paul (right?)
First, about how much I have changed. :) I know that big diffs are hard to
review. And this why I have several branches in my git:
"master" - should be exact copy of SVN version.
"winff-rework" - is UI modifications (including forms renaming and strings
adjusting). This branch is enough to fix this particular Issue. This branch
leads to little modification of .po files, much of which will remain relatively
up-to-date.
"winff-rework-translate" - is translation system modification, which leads to
significant .po files update.
"winff-simba-deb" - is what I used to make a PPA
(https://launchpad.net/~lion-simba/+archive/winff)
I agree that even in "winff-rework" branch three modification sets are mixed:
adding, modifying and shuffling controls around forms; modifying form names;
modifying strings. I'll try to split them.
>> If I understand your changes correct, you needed to create several new
panels to have the text and boxes align in groups, right?
Yes. New panels + "AutoSize" + "Align" + "Anchors" did the job. I haven't test
it with Win32 controls however.
>> What did you need to do to get the translation system reworked? Just the
potranslator.pas file and adding the "hint:" texts to the .lfm files?
Yes. + enabling i18n in "Project options" in Lazarus.
To clarify what it give us:
- no need to manual update .po files from sources;
- no need to duplicate .lfm strings (captions, hints) in .pas files and
assigning them at runtime (see TForm1.FormCreate for example).
Original comment by m...@alexey.osipov.name
on 9 Jan 2011 at 3:10
I will compile them this week and see. I like the screen shots. I will get back
to you as fast as i can
Original comment by bgg...@gmail.com
on 10 Jan 2011 at 11:09
As Paul had requested I have split commits in my git a little more.
To get my commits in order I had to use "git rebase -i", so I'm sorry for any
inconvenience this may led to.
There are several branches now:
"master" - not changed, still a copy of SVN.
"ru-translation" - no changes from SVN, except russian translation updated for
_current_ version of WinFF. In other words, this branch is what I have
published in Issue 107.
"winff-rework" - this branch is fixing this particular issue with no changes to
strings or translations. So it can be transparently used with _current_ WinFF
translations and with my translation from "ru-translation".
"winff-rework-translate" - this branch contains localization system rework
(e.g. enabling i18n in Lazarus, adding potranslator.pas, moving hints from .pas
to .lfm files, etc.) plus many strings changes (in order to clarify what they
actually mean). This branch is NOT compatible with current WinFF translations.
However, it contains fully updated russian translation and partially translated
.po files for other languages.
"winff-simba-deb" is what I used to make a PPA, should be out of interest now.
Also, to clarify stages of my work I have added some tags. This tags explaining
what have been done step by step in context of "winff-rework" branch. There are:
"ru-translation-update" - this is my first change to SVN sources. It contains
the very first version on russian translation I have published in Issue 107.
You may think of it as a start point of my general work.
"cleanup" - clean up the code. Two major changes were done:
1. Line endings in all code files were converted to Unix style (LF). This was
necessary, because Lazarus 0.9.28 always saves modified files using native line
endings. So every change in file leads to git think that the entire file was
modified. If one need to use Windows-style line endings (CRLF), there is an
option in GIT (and SVN too) to do it automatically on checkin/checkout.
2. Lazarus session information (e.g. what forms and code files are open, what
is the current cursor position in code editor, etc) was moved from main project
file (winff.lpi) to separate file (winff.lps), which is untracked by git. This
was done by selecting corresponding option in Lazarus Project Options. This
change allowed me to get rid of many useless diffs and commits.
"renames" - this is the point when I finished renaming things. :) It's just a
bit easier to deal with frmMain, frmPreferences instead of Form1, Form4. Never
need to remember what is for.
All changes from "renames" tag up to "winff-rework" HEAD are adding panels,
setting Align, Anchors and moving controls around, i.e. fixing this Issue.
So now you can choose between accept my work entirely (i.e. merging
"winff-rework-translate" branch) or accept only this Issue fixing part (i.e.
merging "winff-rework"). I'm ready for debates. :)
Original comment by m...@alexey.osipov.name
on 11 Jan 2011 at 9:21
I built the deb with the git changes. I like the layout
improvement with correct HORIZONTAL scaling (vertical scaling is not yet
implemented, i.e. if you set the font size to something large, it still
shows problems in the additional options window). When you shrink the
horizontal width of the winff window, the options button moves OVER the
other buttons, one by one.
Unfortunately I can only check the Russian translation, as other
languages need a rewrite for change in names of the forms. I understand that
you don't want to automatically change them yet.
Original comment by poipodec...@hotmail.com
on 16 Jan 2011 at 2:15
Original comment by bgg...@gmail.com
on 29 Jan 2011 at 8:14
Alexy, your code was accepted some time ago by BiggMatt, but I am missing one
thing. What is the license and copyright of potranslator.pas? I assume it is
GLP3+ and you wrote it, but I need to KNOW.
Original comment by poipodec...@hotmail.com
on 17 Feb 2011 at 8:48
potranslator.pas wasn't actually written by me. I copypaste it from Lazarus
wiki:
http://wiki.lazarus.freepascal.org/Translations_/_i18n_/_localizations_for_progr
ams
section "ranslating Forms, Datamodules and Frames"
Original comment by m...@alexey.osipov.name
on 18 Feb 2011 at 1:53
Thanks for clarifying... Now lets see if I can find the license for that wiki.
Original comment by poipodec...@hotmail.com
on 18 Feb 2011 at 6:24
Original issue reported on code.google.com by
alero...@gmail.com
on 1 Jul 2009 at 7:38Attachments: