search

Pixeltheaertist / Trieste-Port-14

A multiplayer game that takes place in a frontier town on an ocean rig, sitting above an alien ocean. A fork of Space Station 14.
https://spacestation14.io
MIT License
4 stars 10 forks source link

InGas refactor #78

Closed Lyroth001 closed 4 days ago

Lyroth001 commented 1 week ago

About the PR

InWater now can be used to check for any (singular) gas, and should also be able to be called by systems, not needing the component (Havent tested that part tho). Closes #75

Why / Balance

Technical details

read the code :godo:

Media

image

Breaking changes

InWater is now called InGas, parameters have been renamed accordingly

Changelog

Lyroth001 commented 1 week ago

also see #76 should hopefully make it easier

Lyroth001 commented 1 week ago

TECHNICALLY it says your drowning but like. Eh not sure where to change that so

Pixeltheaertist commented 1 week ago

Yeah I can fix the icon if you want, Jellids have a unique one so I can add it in my Jellid branch

Lyroth001 commented 1 week ago

Its the text the icon displays on hover specifically

Pixeltheaertist commented 6 days ago

Its the text the icon displays on hover specifically

Yeah Jellids use the same icon but their text is

Plasmolysis

Your membrane is falling apart!

Lyroth001 commented 6 days ago

Its the text the icon displays on hover specifically

Yeah Jellids use the same icon but their text is

Plasmolysis

Your membrane is falling apart!

Oh neat, I'll check how you do that probablt tmrw then!

Pixeltheaertist commented 6 days ago

want me to merge this now or wait?

Lyroth001 commented 5 days ago

Good to merge now, tested it and it works fine, actually clears the alert when not in the gas as well now lmao

Pixeltheaertist commented 4 days ago

copy copy, i can't test it but i trust you O7

Pixeltheaertist commented 4 days ago

@Lyroth001 do you know if it sets any kind of public variable to true or should i add that when i get home

like if an entity is in water it sets that fact to true so other systems can do special things if they are in water i'm also going to make a new issue for things to have water to do that i need to code at some point

THANKS FOR THE CONTRIBUTION! This is big time help

Lyroth001 commented 4 days ago

@Lyroth001 do you know if it sets any kind of public variable to true or should i add that when i get home

like if an entity is in water it sets that fact to true so other systems can do special things if they are in water i'm also going to make a new issue for things to have water to do that i need to code at some point

THANKS FOR THE CONTRIBUTION! This is big time help

Currently no variable, but you should be able to call inGas() to check, which should (In theory I havent tested it) be able to be called on entities without the component as well (although adding a var to the component wouldn't be too hard)