Fix closing the browser and effectively making Karma stuck when using singleRun option

dos1 commented 9 years ago

There were a few problems that prevented selenium-webdriver-launcher to work properly with singleRun option:

the browser id wasn't passed to the browser in URL, so the browser generated a new ID, which Karma then treated as a unrelated, new browser
lack of baseBrowserDecorator prevented some internal browser registration code from being called
after adding baseBrowserDecorator, self.forceKill was defined erroneously (killingPromise was referring to the one in decorator's scope, which was never set due to self.kill being redefined in SeleniumWebdriverBrowser)

PixnBits commented 9 years ago

Good stuff, thanks for fixing that!

erykpiast commented 9 years ago

:+1: Are you going to publish on NPM new version containing those fixes?

PixnBits commented 9 years ago

oops, got busy at work :-1: I can give @dos1 access to do so, if you wish? might be faster than I'll be :(

PixnBits commented 9 years ago

I don't see @dos1 on npm :frowning:

dos1 commented 9 years ago

Try again :)

PixnBits commented 9 years ago

published in the meantime

PixnBits commented 9 years ago

and added! :tada:

dos1 commented 9 years ago

Great, thanks! :+1:

PixnBits / karma-selenium-webdriver-launcher