search

Pixplicity / gene-rate

Generate a better rating for your Android app
Apache License 2.0
67 stars 17 forks source link

On emulator canRateApp() returns false #11

Closed soenkegissel closed 6 years ago

soenkegissel commented 6 years ago

I am testing on an emulator and it took me a while to figure out canRateApp() is returning false, so a request is never shown. You can check if the device is an emulator and return accordingly.

kassim commented 6 years ago

I think if you use one of the emulators that have Google Play Store on you should be able to test it

screen shot 2018-02-23 at 10 11 45
soenkegissel commented 6 years ago

The canOpenIntent(Intent) can return 0 if the emulator has no app to open Intent.ACTION_VIEW. I checked showRequest() what the return of canRateApp() is - it is sometimes false on emulator.

kassim commented 6 years ago

yeah it'd be false if there's no Google Play Store app installed, hence why I recommend you using one of the emulators that do have it installed

soenkegissel commented 6 years ago

Hmm. I have to admit I could have tested it on a device with no PlayStore installed. Thank you very much.

kassim notifications@github.com schrieb am Fr., 23. Feb. 2018 um 14:42 Uhr:

yeah it'd be false if there's no Google Play Store app installed, hence why I recommend you using one of the emulators that do have it installed

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/Pixplicity/gene-rate/issues/11#issuecomment-368011957, or mute the thread https://github.com/notifications/unsubscribe-auth/AMumDHgx6iq4pmOYO5PW-0R3-j_adG_Yks5tXsA1gaJpZM4R8w4d .