Suppress debug messages

Pixplicity / sharp

Scalable vector graphics for Android

Apache License 2.0

1.03k stars 117 forks source link

Suppress debug messages #20

Closed mlagerberg closed 8 years ago

mlagerberg commented 8 years ago

The library floods logcat with messages.

Desired functionality:

Add a method .setDebugEnabled(boolean) to suppress trivial messages,
Change some of the messages from level DEBUG to level VERBOSE (such as Parsing complete in 9 ms.),
Log similar messages only once per session (such as Unrecognized SVG command: clipPath).

filipc commented 8 years ago

Most messing messages moved to VERBOSE log level.

filipc commented 8 years ago

Question about setDebugEnabled() method - do you mean to use external library like android-logger (https://github.com/noveogroup/android-logger) ?

Skipping similar messages forces collecting of logs. I think it is not good idea.

pflammertsma commented 8 years ago

No, we don't intend to include external libraries for logging as a part of Sharp. setDebugEnabled(boolean) simply suppresses Log.v and Log.d from being executed.

I believe it may be a better approach to offer a facility to set the log level.

pflammertsma commented 8 years ago

I agree that we should not display messages once per session. An implementation is likely to cache (for instance to a bitmap), so it may be up to the implementation to suppress repeated messages.

In general, those scenarios where Sharp produces errors or warnings for otherwise valid SVGs should gradually be resolved with improvements to the library.