Remove deprecated methods, code cleanup

Pixplicity / sharp

Scalable vector graphics for Android

Apache License 2.0

1.03k stars 117 forks source link

Remove deprecated methods, code cleanup #24

Closed filipc closed 8 years ago

filipc commented 8 years ago

According to #23 deprecated methods was removed. I also did some code cleanup:

there was unnecessary hidden2 value, mWhiteMode,
method angle had typos in param names,
unused private method getHexAttr, pathStyleHelper, toFloat
p had assignments just before return
there was redundant class Line that was replaced by RectF

filipc commented 8 years ago

Any chance to merge my changes?

pflammertsma commented 8 years ago

Sorry to leave this hanging, @filipc, I'm struggling with the idea of dropping public API methods. I'm concerned some users are using this in the wild and this may break their implementations.

I'd lean towards incorporating this in a next major release. On the other hand, the methods have been deprecated ever since initial release.

pflammertsma commented 8 years ago

I bit the bullet and merged it. Thanks for your contributions, @filipc!