search

Piyotato / pe

0 stars 0 forks source link

Overzealous input validation for phone number #6

Open Piyotato opened 1 year ago

Piyotato commented 1 year ago

Although phone numbers in Singapore are always at least 8 digits long, we cannot assume that this will never change in the future. To me, this seems to be overzealous in terms of input validation.

nus-pe-script commented 1 year ago

Team's Response

Thank you for your bug report!

However, our team believes that a minimum of 8 digits is not an overzealous validation. Especially as we feel that at least 8 digit seems to be a reasonable limit.

image.png

We feel that if there is a need to change the format of a phone number in the future, it would be changed to a number that has more than 8 digits rather than a number that is shorter than 8 digits. Especially when the number of digits has been increasing rather than decreased.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]