search

Pizzalol / SpellLibrary

Repo for recreating the original dota skills
Other
337 stars 123 forks source link

Desolator Datadriven Bug #59

Closed EarthSalamander42 closed 8 years ago

EarthSalamander42 commented 8 years ago

I'm using it in X Hero Siege( again ) and the first shot applies armor reduction after the damage, wich makes the difference not a big deal, but with a modified deso that reduce armor from -100 per example you feel it when the first shot deals like 50 dmg, and the 2nd 700.

MNoya commented 8 years ago

Just change the apply effect to OnOrbFire instead of OnOrbImpact

EarthSalamander42 commented 8 years ago

Will it apply if the Attack is missed?

vVv-AA commented 8 years ago

Misses are not supposed to apply Desolate if it works as in Dota.

EarthSalamander42 commented 8 years ago

Okay i thought it was needed to mention in code to not apply if missed, thanks for the help works fine, i think you guys should make the change too in the spell Library!

fcalife commented 8 years ago

Is your desolator supposed to do anything beyond the regular one's effects? Wouldn't it be easier to edit it instead?

2015-12-14 15:26 GMT-03:00 Cookies notifications@github.com:

Okay i thought it was needed to mention in code to not apply if missed, thanks for the help works fine, i think you guys should make the change too in the spell Library too!

— Reply to this email directly or view it on GitHub https://github.com/Pizzalol/SpellLibrary/issues/59#issuecomment-164517805 .

Felipe Calife

EarthSalamander42 commented 8 years ago

Yes it should, and with noya's fix it does, but what i'm trying to say is that the datadriven desolator should apply damage before impact, as the regular does in dota 2