search

Pjbomb2 / TrueTrace-Unity-Pathtracer

A High Performance Compute Shader Based Mesh Pathtracer in Unity3d without RT Cores
MIT License
705 stars 47 forks source link

Provide Unity package #9

Closed cpetry closed 9 months ago

cpetry commented 1 year ago

Hello there!

Looks like a very promising project. Can you provide this as a Unity package with a package.json? Would gladly test it out on my project.

Pjbomb2 commented 1 year ago

It should include a unity package?

cpetry commented 1 year ago

Sorry, guess my request wasn't clear enough. I meant a package that can be referenced by the package manager directly. See here https://docs.unity3d.com/Manual/CustomPackages.html

That means that you only need to create a package.json with some details here in this GitHub repository in the upmost folder.

Pjbomb2 commented 1 year ago

ohhhh!! ok! yeah ill work on that! lemme get the xml creation done first here tho

cpetry commented 1 year ago

Created a pull request on this topic. Check if this fits for you. With this you won't need to build a *.unityPackage anymore as users can directly reference this repo

As I forked it you can currently just use this path and add it in the package manager "https://github.com/cpetry/TrueTrace-Unity-Pathtracer.git?path=/TrueTrace". Git and Unity handles the rest.

cpetry commented 1 year ago

Hello again,

I would like to test out your latest changes. Currently though you only update the .unityPackage und don't work at all on the repo directly anymore. Is there a reason for this? As already explained above: No need for a .unityPackage anymore when working with packages

Pjbomb2 commented 1 year ago

Sorry! Forgot this was even a thing and how it worked lol do you mean I dont update the normal scripts in the github? I just havent out of laziness as I didnt remember the purpose of keeping it updated, but I will update that tomorrow!

On Wed, Aug 2, 2023 at 10:11 PM cpetry @.***> wrote:

Hello again,

I would like to test out your latest changes. Currently though you only update the .unityPackage und don't work at all on the repo directly anymore. Is there a reason for this? As already explained above: No need for a .unityPackage anymore when working with packages

— Reply to this email directly, view it on GitHub https://github.com/Pjbomb2/TrueTrace-Unity-Pathtracer/issues/9#issuecomment-1663299860, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHOHN4MXDVHMMNUBRTVJCHDXTMXJBANCNFSM6AAAAAAXCOWSNI . You are receiving this because you commented.Message ID: @.***>

-- Thank you for taking time out of your day to read this message. Have a good day! -Payton Leather

cpetry commented 1 year ago

Great! Yeah please keep the scripts and changes updated. The *.unitypackage is not needed at all