search

Place1 / node-gir

Node bindings to libgirepository
http://live.gnome.org/GObjectIntrospection
MIT License
27 stars 6 forks source link

Added prettier support #17

Closed clayrisser closed 6 years ago

clayrisser commented 6 years ago

This fixes issue #16

ewnd9 commented 6 years ago

There is also an eslint plugin https://github.com/prettier/eslint-plugin-prettier although the project only contains cpp linting now

Place1 commented 6 years ago

i'd be keen to add eslint with the plugin to be honest. @jamrizzi would you like to update this PR to add eslint with the prettier plugin (as well as npm script for linting js code).

clayrisser commented 6 years ago

I’ll add eslint, but that doesn’t replace prettier. Many JavaScript developers are using it now, and without prettierrc single quotes will get replaced by double quotes.

Place1 commented 6 years ago

Yeah I just meant add eslint with the prettier plugin. The plugin uses your eslint config to auto fix linter errors. If you eslint config specifies a specific quote style (I.e single quotes) then when you run “eslint --fix” it will use prettier to fix the code.

On Sun, 11 Feb 2018 at 1:21 pm, Jam Risser notifications@github.com wrote:

Closed #17 https://github.com/Place1/node-gir/pull/17.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Place1/node-gir/pull/17#event-1468257266, or mute the thread https://github.com/notifications/unsubscribe-auth/ALMBlnoyx5zTTxUQPZKRBl5S6_bA_hf2ks5tTk60gaJpZM4SA9Sf .

clayrisser commented 6 years ago

I created a new issue for eslint. I’ll add it tomorrow. #23