search

Place1 / node-gir

Node bindings to libgirepository
http://live.gnome.org/GObjectIntrospection
MIT License
27 stars 6 forks source link

Eslint #23

Closed clayrisser closed 6 years ago

clayrisser commented 6 years ago

As stated in issue #17, eslint should be added. I nominate using the Airbnb style guide. The code already seems to follow it closely. Any thoughts?

Place1 commented 6 years ago

yeah that's fine with me

On Sun, Feb 11, 2018 at 1:23 PM, Jam Risser notifications@github.com wrote:

As stated in issue #17 https://github.com/Place1/node-gir/pull/17, eslint should be added. I nominate using the Airbnb style guide. The code already seems to follow it closely. Any thoughts?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Place1/node-gir/issues/23, or mute the thread https://github.com/notifications/unsubscribe-auth/ALMBlq525bJF1XnzzQ8XSMZO1ib3sLvUks5tTk8mgaJpZM4SBK7N .

clayrisser commented 6 years ago

I disabled the following airbnb rules.

no-plusplus new-cap global-require

Place1 commented 6 years ago

Any reason to disable no-cap? Thats a pretty standard rule.

On Mon, 12 Feb 2018 at 4:57 am, Jam Risser notifications@github.com wrote:

I disabled the following airbnb rules.

no-plusplus https://eslint.org/docs/rules/no-plusplus new-cap https://eslint.org/docs/rules/new-cap global-require https://eslint.org/docs/rules/global-require

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/Place1/node-gir/issues/23#issuecomment-364772186, or mute the thread https://github.com/notifications/unsubscribe-auth/ALMBlshAYbVI4-7aQbGw1Nl83TyY_0XRks5tTyoQgaJpZM4SBK7N .

clayrisser commented 6 years ago

Yes, there are classes coming from gobject that are not lowercase. I'm not exactly sure why. I can look into it further, but for now, the best temporary solution is to disable new-cap.

I could disable it with a comment if you want?

Place1 commented 6 years ago

Nah that’s fine. We can always tighten it up later.

On Mon, 12 Feb 2018 at 10:07 am, Jam Risser notifications@github.com wrote:

Yes, there are classes coming from gobject that are not lowercase. I'm not exactly sure why. I can look into it further, but for now, the best temporary solution is to disable new-cap.

I could disable it with a comment if you want?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Place1/node-gir/issues/23#issuecomment-364798735, or mute the thread https://github.com/notifications/unsubscribe-auth/ALMBlsoshcXtnEOqr3Bzu93YBoTo85viks5tT3KYgaJpZM4SBK7N .