search

Placeholder-Software / Dissonance

Unity Voice Chat Asset
71 stars 5 forks source link

Use assembly definitions #161

Closed lemcheyWhite closed 5 years ago

lemcheyWhite commented 5 years ago

Hi, It would be nice to have assembly definitions (https://docs.unity3d.com/Manual/ScriptCompilationAssemblyDefinitionFiles.html) for the main project (Dissonance) and for integration as well. Do you have any plans to implement it?

Thank you!

lemcheyWhite commented 5 years ago

Found related issue #101, but I can't see asmdef in package preview\import window.

martindevans commented 5 years ago

Dissonance doesn't ship with asmdefs at the moment as not everyone uses them in their project and they're a bit inconvenient in that case. Instead we've made sure that it's relatively easy to add asmdefs to Dissonance if you need them - check out the instructions on how to add asmdefs here.

martindevans commented 5 years ago

I should mention that #101 (when we made this decision) was almost a year ago. We'll probably add asmdefs to the package in the near future, as more and more people are using them.

lemcheyWhite commented 5 years ago

I've tried to use the instruction but looks like it doesn't work anymore as excepted For example: NotNullAttribute class is internal in Dissonance\Core\Jetbrains, but it's used in Dissonance\Editor classes and when I add assembly definitions, class NotNullAttribute is not accessible anymore from Editor assembly.

It's only one example, as a workaround I can change accessor modified to public in this case, but it requires a lot of work after upgrade to a new version.

martindevans commented 5 years ago

I'll investigate this soon and (hopefully) it'll all be fixed up by the next release :)

martindevans commented 5 years ago

With Dissonance 6.4.3 we've added assembly definitions to Dissonance.