search

Placeholder-Software / Dissonance

Unity Voice Chat Asset
69 stars 5 forks source link

Unity 2021.2.0f1 breaks Dissonance #242

Closed peterparnes closed 2 years ago

peterparnes commented 2 years ago

Context

Unity 2021.2.0f1 breaks Dissonance-script.

Dissonance\Integrations\MirrorIgnorance\MirrorIgnoranceCommsNetwork.cs(232,20): error CS0029: Cannot implicitly convert type 'void' to 'System.ArraySegment'

Dissonance\Integrations\MirrorIgnorance\MirrorIgnoranceCommsNetwork.cs(117,36): error CS1503: Argument 1: cannot convert from 'void' to 'System.ArraySegment'

Steps to Reproduce

Open a project with Dissonance in 2021.2.0f1 and check the console.

Your Environment

Include as many relevant details about the environment you experienced the bug in

martindevans commented 2 years ago

Thanks for reporting this. This has happened because Unity has added a new method to ArraySegment in 2021 called CopyTo, this overrides the extension method that Dissonance had already defined. Unfortunately the Unity method has a different signature so you get this error.

I'll release a hotfix for it ASAP. Until that is available; you should be able to fix this by replacing all uses of CopyTo with CopyToSegment.

martindevans commented 2 years ago

Version 8.0.3.1 is now live on the asset store with this fix.