search

Placeholder-Software / Dissonance

Unity Voice Chat Asset
71 stars 5 forks source link

[BUG] UNet HLAPI : Server Logs Errors When Clients Disconnect #56

Closed GabeBigBoxVR closed 6 years ago

GabeBigBoxVR commented 6 years ago

Context

The server is logging exceptions when a client disconnects from the server. Normally this probably shouldn't happen since it's part of normal behavior to connect/disconnect.

Disconnected in HLAPI
0x000000014099343B (Unity) StackWalker::GetCurrentCallstack
0x000000014099695F (Unity) StackWalker::ShowCallstack
0x0000000140D3C6C0 (Unity) GetStacktrace
0x0000000141082F46 (Unity) DebugStringToFile
0x000000014108371C (Unity) DebugStringToFile
0x0000000141875022 (Unity) DebugLogHandler_CUSTOM_Internal_Log
0x0000000038A868BB (Mono JIT Code) (wrapper managed-to-native) UnityEngine.DebugLogHandler:Internal_Log (UnityEngine.LogType,string,UnityEngine.Object)
0x0000000038A867A4 (Mono JIT Code) [DebugLogHandler.cs:9] UnityEngine.DebugLogHandler:LogFormat (UnityEngine.LogType,UnityEngine.Object,string,object[]) 
0x0000000038A86095 (Mono JIT Code) [Logger.cs:47] UnityEngine.Logger:Log (UnityEngine.LogType,object) 
0x000000003D265173 (Mono JIT Code) [DebugBindings.gen.cs:124] UnityEngine.Debug:LogError (object) 
0x000000003D18BE38 (Mono JIT Code) [HlapiServer.cs:74] Dissonance.Integrations.UNet_HLAPI.HlapiServer:Update () 
0x000000003D18B553 (Mono JIT Code) [BaseCommsNetwork.cs:128] Dissonance.Networking.BaseCommsNetwork`5/Session<Dissonance.Integrations.UNet_HLAPI.HlapiServer, Dissonance.Integrations.UNet_HLAPI.HlapiClient, Dissonance.Integrations.UNet_HLAPI.HlapiConn, Dissonance.Unit, Dissonance.Unit>:Update () 
0x0000000038B0C0D1 (Mono JIT Code) [BaseCommsNetwork.cs:296] Dissonance.Networking.BaseCommsNetwork`5<Dissonance.Integrations.UNet_HLAPI.HlapiServer, Dissonance.Integrations.UNet_HLAPI.HlapiClient, Dissonance.Integrations.UNet_HLAPI.HlapiConn, Dissonance.Unit, Dissonance.Unit>:Update () 
0x0000000038B0BE5A (Mono JIT Code) [HlapiCommsNetwork.cs:62] Dissonance.Integrations.UNet_HLAPI.HlapiCommsNetwork:Update () 
0x00000000031F7622 (Mono JIT Code) (wrapper runtime-invoke) object:runtime_invoke_void__this__ (object,intptr,intptr,intptr)
0x00007FFE67035FEB (mono) [mini.c:4937] mono_jit_runtime_invoke 
0x00007FFE66F88765 (mono) [object.c:2623] mono_runtime_invoke 
0x00000001414136E5 (Unity) scripting_method_invoke
0x000000014140B981 (Unity) ScriptingInvocation::Invoke
0x0000000141162BBB (Unity) MonoBehaviour::CallMethodIfAvailable
0x000000014117B3DF (Unity) MonoBehaviour::CallUpdateMethod
0x0000000140DDA8D6 (Unity) BaseBehaviourManager::CommonUpdate<BehaviourManager>
0x0000000140DDB56F (Unity) BehaviourManager::Update
0x00000001410BE2B3 (Unity) `InitPlayerLoopCallbacks'::`38'::UpdateScriptRunBehaviourUpdateRegistrator::Forward
0x00000001410BC145 (Unity) PlayerLoop
0x0000000140108FCE (Unity) Application::UpdateScene
0x000000014010D4EF (Unity) Application::UpdateSceneIfNeeded
0x000000014013142F (Unity) Application::TickTimer
0x0000000141A9319D (Unity) MainMessageLoop
0x0000000141A94AAE (Unity) WinMain
0x0000000141CF8CAC (Unity) __tmainCRTStartup
0x00007FFEA3122774 (KERNEL32) BaseThreadInitThunk
0x00007FFEA3850D51 (ntdll) RtlUserThreadStart

Expected Behavior

Don't log client disconnects as an error.

Actual Behavior

Error is getting logged

Workaround

Comment out Debug.Log("Disconnected in HLAPI");

Steps to Reproduce

  1. Connect to Server from a client
  2. Client should disconnect
  3. Observe server logs error

Your Environment

Windows 10 VR

martindevans commented 6 years ago

Oops, that was a debugging print that should never have made it into release!

martindevans commented 6 years ago

Dissonance 3.0.3 just went live on the asset store with this print statement removed. I'll close this issue now, feel free to re-open it if this continues to be a problem.