search

Placeholder-Software / Dissonance

Unity Voice Chat Asset
71 stars 5 forks source link

Buid error for UWP (Hololens) #61

Closed awonnink closed 6 years ago

awonnink commented 6 years ago

Hi, I get a error when trying to build for UWP (HoloLens D3D) on saying 'CS0117: 'Math' does not contain a definition for 'DivRem''. It is used in the PacketLossMonitor.

I am working with Dissonance 3.0.2 now, and this compiles correctly for PC. The Unity version is 2017.1.1f1, My system Windows 10 x64

I guess the solution is just to add your own DivRem function (after commenting the relevant lines out, it compiles ok)

Albert Jan

martindevans commented 6 years ago

That's an odd thing to be missing! As you suggest we'll just have to write our own DivRem. We're doing the last work for the next release today, so we might squeeze that in at the last minute.

TomGillen commented 6 years ago

We have just merged in a small fix for this in our internal builds. If you want to make the change yourself rather than wait for a new release, then replace the line calling DivRem with:

var midIndex = (int) Math.Ceiling((_tmpLossValues.Count - 1) / 2.0f);
awonnink commented 6 years ago

Great, thank you both!

martindevans commented 6 years ago

Dissonance 3.0.3 just went live on the asset store with this fix merged in. I'll close this issue now, feel free to re-open it if this continues to be a problem.

Edit: Oops, you'd already closed it and I inadvertently re-opened it!