search

Placeholder-Software / Dissonance

Unity Voice Chat Asset
71 stars 5 forks source link

[Bug] SendUnreliableP2P in base client is relayed over the reliable channel #88

Closed christjt closed 6 years ago

christjt commented 6 years ago

Context

Creating my own integration and found that when relaying voice data from the server it is sent over the reliable channel. This does noe seem to be intended.

Expected Behavior

I expect SendUnreliableP2P to relay data over the unreliable channel

Actual Behavior

It is sent over reliable channel.

Workaround

change in BaseClient.SendUnreliableP2P:
writer.WriteRelay(_serverNegotiator.SessionId, destinations, packet, true);

to
writer.WriteRelay(_serverNegotiator.SessionId, destinations, packet, false);

Your Environment

Dissonance version v6.1.0

martindevans commented 6 years ago

Thanks for the report, you're absolutely right with both the problem and the workaround. Coincidentally someone reported this same issue a few days ago and we have the fix ready to go with the next version of Dissonance :)

martindevans commented 6 years ago

Dissonance 6.2.0 has just been submitted to the asset store, this includes the (un)reliable relay fix. This should be available in a few days once the asset store team reviews it :)

martindevans commented 6 years ago

Dissonance 6.2.0 is now available on the asset store so I'll close this issue now. Don't hesitate to re-open it if there's still a problem :)