search

Placekey / placekey-py

https://placekey.io
Apache License 2.0
59 stars 8 forks source link

Stop PK API client from modifying root logger #11

Closed roshan closed 3 years ago

roshan commented 3 years ago

Previously, importing the placekey module would cause it to immediately suppress all but logging.ERROR logs in any code that it is imported into. This is somewhat unexpected since you'd expect that importing a module doesn't have side-effects on the rest of your program.

This makes it so that the logging settings in this module apply to this module.

felixsafegraph commented 3 years ago

@rmtrmt I had forgot about this. what setup we need in github Action to get the tests to pass?

rmtrmt commented 3 years ago

@rmtrmt I had forgot about this. what setup we need in github Action to get the tests to pass?

The tests aren't passing because PRs from forks don't have access to the repo secrets. We'll need to reopen this PR from a branch in this repo.

felixsafegraph commented 3 years ago

@rmtrmt should we just move this PR then?

rmtrmt commented 3 years ago

I've duplicated this PR from a branch in this repo, so I'm closing this PR.