search

Placekey / placekey-py

https://placekey.io
Apache License 2.0
59 stars 8 forks source link

Not sure why, but this makes it work with pyinstaller #21

Closed Daniel-Vetter-Coverwhale closed 1 year ago

Daniel-Vetter-Coverwhale commented 1 year ago

First let me say how cool this whole project is! I think you guys doing a really good thing by trying to introduce a cleaner form of location matching. It was really easy to get an api key and get started, and it's awesome that using the API is free in general!

I had no problems using this package directly, but when trying to run a PyInstaller built executable I was getting this

    from placekey.api import PlacekeyAPI
  File "PyInstaller/loader/pyimod02_importers.py", line 499, in exec_module
  File "placekey/api.py", line 7, in <module>
  File "PyInstaller/loader/pyimod02_importers.py", line 499, in exec_module
  File "placekey/__init__.py", line 1, in <module>
ModuleNotFoundError: No module named 'placekey.__init__.placekey'

which I assume has to do with the oddities of PYTHONPATH or something 🤷 . I attempted to add many different combinations of things as PyInstaller hidden-imports to no avail. However, changing this allows it to run successfully, and doesn't seem like it will break anything else. Since the change seems innocuous, and fixes an issue for me and maybe others I figured I'd open this PR.

Thanks for your time!

felixsafegraph commented 1 year ago

seems safe - we will test it out before rolling the release. thanks for your contribution!