Placeware / ThisPlace

:globe_with_meridians: Remember a 3x3 m² location anywhere in the world with just four words.
https://thisplace.herokuapp.com
MIT License
19 stars 12 forks source link

First version of the info box #25

Closed betatim closed 10 years ago

betatim commented 10 years ago

Added a infobox to the map page which dispalys the 4words and the lat/lng of the marker.

kdungs commented 10 years ago

This is awesome! Good job.

betatim commented 10 years ago

Fixes #10

Tried to copy a bit from gmaps (as usual). Decided against showing the street address though.

Do you know how to make the 4words a link? Would like it to look like normal text but once you hover, it reveals itself to be a link to that page. Just in case there is someone who doesn't get the concept. Useful?

What to do with all the white space? Keep it clean.

betatim commented 10 years ago

Apparently referencing the issue after the merge doesn't auto close it? Closed by hand

kdungs commented 10 years ago

Making it a link should be something like

Dirty:

bla.innerHTML = '<a href="/' + fourwords + '">' + fourwords + '</a>';

Clean(er):

var blu = bla.appendChild(document.createElement('a'));
blu.setAttribute('href', '/' + fourwords);
blu.innerHTML = fourwords;

Just from the top of my head and not actually tested.

kdungs commented 10 years ago

And for mobile I would add an option to collapse the info box. Something like this: screen shot 2014-11-26 at 11 49 39 pm where of course each button only shows up when necessary and looks much nicer...