search

PlagiarismCheck / moodle-plagiarism_pchkorg

Plagiarismcheck.org is a sophisticated similarity search engine. We advocate for bringing technology into academics to help instructors save time and motivate students write better papers.
https://plagiarismcheck.org
GNU General Public License v3.0
13 stars 4 forks source link

Update lib.php "Support student custom roles" #29

Closed llewelyn-williams closed 1 year ago

llewelyn-williams commented 1 year ago

8862dc0 introduced a bug that caused the widget to be disabled for an excess of Moodle user roles when the Plugin is set to No for Students can see a similarity score, as users became considered "Students" as per $isstudent even if they were not students.

This change I believe was intentional, but to be applied where $isstudent is reassigned for the purpose of $role in auto_registrate_member($name, $email, $role)

I believe that this would have had the intended effect of avoiding real world students that don't have the specific named role 'student' on Moodle (i.e. having a custom role that uses the 'student' archetype but a different role name) from being given 'Teacher' role and permissions on plagiarismcheck.org

JaneAdelmann commented 1 year ago

This MR is available in version v3.13.5

JaneAdelmann commented 1 year ago

Thank you for contribution.