Add retry support for document cmdlets

PlagueHO / CosmosDB

PowerShell Module for working with Azure Cosmos DB databases, collections, documents, attachments, offers, users, permissions, triggers, stored procedures and user defined functions.

http://dscottraynsford.com

MIT License

152 stars 46 forks source link

Add retry support for document cmdlets #444

Open Szeraax opened 2 years ago

Szeraax commented 2 years ago

Adds enhancement #442

Style guide suggests that using splatting is cool, so I also changed some commands with immediate execution to use splatting.

Marking PR as draft.

Implements parameters for document cmdlets
Implements parameters for Invoke-CosmosDbRequest
Does not yet include any unit tests
Does not yet include any PlatyPS documentation

@PlagueHO Note: There is no dev branch to open the PR against according to the contrib document. Opening against main.

This change is

PlagueHO commented 2 years ago

Ah right, looks like I need to update the contrib doc - no longer use dev/master. Changed to main - so all good.

Szeraax commented 2 years ago

I'll look at the tests and platyps stuff next week when I have some more time if you or other don't get to it first.

Loving the module so far! Great work.

PlagueHO commented 2 years ago

Just a couple of style/consistency nitpicks:

Tend to avoid using type accelerators, so [int] to `[System.Int32]' etc.
Use lower case first letter for local variable names.
Avoid using generic $splat variable name, rather name with indicator of use (sometimes not possible if used with multiple cmdlets): e.g. $invokeCosmosDbRequest_parameters

I adopted the style and practices we adopted over the PowerShell DSC modules :grin:

Szeraax commented 2 years ago

K, I'll go update those.

PlagueHO commented 2 years ago

Awesome! Thank you for putting time into this! I've had so little time lately to work on stuff - so much appreciated.

Szeraax commented 2 years ago

Hope you squash PR's on merge for this.

Using this module, I've been able to rapidly prototype an AzureFunctions frontend with Cosmos DB in 2 days that has been plagued by issues in Azure SQL RDMS for months. SOOOO nice being able to just use a JSON document instead of trying to replicate relationships of data across about 7 tables.