Closed MS-MatthewWalker closed 8 years ago
Cool - this has been on my todo list since I first started this project :smile:
Suggestion:
I am presuming the Prefix is used to append "Win2016-" onto the beginning of the VHDx filename?
If so, then perhaps make the
Also, how will the path to the Source ISO that will build these templates be provided?
Have you made a fork of this repo? You'll want to do that first so you can make changes to your fork and the submit the PR from that fork (or a branch of your fork most likely). Also, submit PR's to the Dev branch of this repo rather than master.
Ok, that makes sense for the prefix – I already have all the code to do this, just modifying to fit the format. Some of which is borrowed from your nanoserver creation script ☺
On mine I added the source iso into settings I’ll do that as soon as I figure out how to fork it
Like I said I’m still learning ☺
From: Daniel Scott-Raynsford [mailto:notifications@github.com] Sent: Wednesday, February 10, 2016 6:27 PM To: PlagueHO/LabBuilder LabBuilder@noreply.github.com Cc: Matthew Walker mwalker@dragon-reach.com Subject: Re: [LabBuilder] Add function to create template disks from ISO image (#27)
Cool - this has been on my todo list since I first started this project [:smile:]
Suggestion:
I am presuming the Prefix is used to append "Win2016-" onto the beginning of the VHDx filename? If so, then perhaps make the a property of the for each template.
Also, how will the path to the Source ISO that will build these templates be provided?
Have you made a fork of this repo? You'll want to do that first so you can make changes to your fork and the submit the PR from that fork (or a branch of your fork most likely). Also, submit PR's to the Dev branch of this repo rather than master.
— Reply to this email directly or view it on GitHubhttps://github.com/PlagueHO/LabBuilder/issues/27#issuecomment-182654687.
Oh I just realized I already have an attribute in the for controlling the ISO to use to create the template disk. It is: installiso=".\Tests\PesterTestConfig\10240.16384.150709-1700.TH1_CLIENTENTERPRISE_VOL_X64FRE_EN-US.iso"
Ok, apparently I screwed - pull request went to your dev branch and i was just trying to update my fork.
So PR #35 was not meant to be a PR, but a commit to your own fork? If so, just cancel/close the PR. :smile:
FYI, I've nearly completed Issue #9 (Support for multiple VHDs). You can see it in this branch.
Once it is complete (later on today) I'll merge this change down into my Dev branch. What you'll then want to do is fetch my dev branch and merge it down into your dev branch.
The commands to do this are (in case you're interested):
cd <LabBuilder folder on your local machine>
; pull the upstream dev branch (my dev branch) down into your local git repository
git fetch upstream dev
; make sure your dev branch is the currently checked out branch
git checkout dev
; merge changes from my my dev branch into your dev branch
git merge upstream\dev
Your local dev branch will then have your changes as well as the new changes I've made.
Thanks
I'll close this issue now because it has been merged.
`
`
XML syntax - Once I have the function written I will add and submit pull request