search

PlaidWeb / webmention.js

Client-side library for rendering webmentions from webmention.io
MIT License
112 stars 16 forks source link

Add LibreJS license information to webmention.js #39

Closed marceline-cramer closed 2 years ago

marceline-cramer commented 2 years ago

I added comments for GNU LibreJS to pick up on the licensing in the main webmention.js source file. This won't show up in the minified code, but people who care about hosting free-as-in-freedom JavaScript probably won't be hosting minified JavaScript on their site anyways (like me). Note that the reason that the initial @license is in a single-line comment and not a multiline comment because the current version of LibreJS does not pick up on tags in multiline comments: https://savannah.gnu.org/bugs/?59200

fluffy-critter commented 2 years ago

Hmm, is there some reason why the license is kept at a magnet URL? Those aren't exactly easy to access. I'm not familiar with GNU LibreJS but surely it allows the URL to point to, say, https://github.com/PlaidWeb/webmention.js/blob/main/LICENSE instead?

fluffy-critter commented 2 years ago

Looking at the docs it looks like magnet links are the appropriate way of linking to a license, and while the multi-line embed is the better way to do it that's currently not working, as you mentioned. I guess the magnet URL is fine.