search

PlaidWeb / webmention.js

Client-side library for rendering webmentions from webmention.io
MIT License
112 stars 16 forks source link

Allow configuring webmentions fetched per page #7

Closed jamietanna closed 5 years ago

jamietanna commented 5 years ago

Instead of defaulting to how many Webmention.io returns (20 at time of writing) we should allow folks to configure it themselves via another script parameter.

jamietanna commented 5 years ago

Thanks! It's something I've worked around on my copy, but thought I should really upstream the changes!

fluffy-critter commented 5 years ago

If I had my druthers I guess I'd want to make the default higher, or make it defer to the endpoint's default instead of baking another default in here, but that's pretty minor.

jamietanna commented 5 years ago

That's fair - 20 is the default from webmention.io, but we could always tweak this so it only specifies per-page if the attribute is set - want me to raise an issue for maybe someone Hacktoberfest-y to pick it up?

fluffy-critter commented 5 years ago

Eh, it seems like a simple enough change to make when i get around to it. Opened issue #8