8 database create user saved recipes model in db - Githubissues

Plan-My-Dinner / plan_my_dinner_be

Backend Service Repo for the Plan My Dinner Application

https://planmydinner.fly.dev/

0 stars 0 forks source link

8 database create user saved recipes model in db #25

Closed ross-ian28 closed 1 year ago

ross-ian28 commented 1 year ago

What Type of PR is this?

[x] 🎁 Feature
[ ] 🐞 Bug Fix
[ ] 📝 Documentation Update
[x] 🛠️ Code Refactor
[ ] 🔥 Performance Improvements
[x] ✅ Test
[ ] 🤖 Build / CI/ DevOps
[ ] ⏪️ Revert
[ ] 🙋 Request for Help
[x] 💎 Adds dependencies
[x] 📊 Changes DB
[ ] 👽 Other: explain here
Describe your changes

^{Created the saved_recipies table in the database and created the SavedRecipie model, with corresponding test}

Issue number and link

^{Issue 8: https://github.com/Plan-My-Dinner/plan_my_dinner_be/issues/8}

Questions for reviewers?

^{The saved_recipies_spec.rb test does not pass, comments in the file explain the error}

Checklist before requesting a review

Repo Contribution Standards	Complete
I have performed a self-review of my code	[x] Yes [ ] No
My code follows the style guidelines of this project	[x] Yes [ ] No
I have made corresponding changes to the documentation (Note: Documentation must be up to date for merge)	[x] Yes [ ] No

Change Type	Complete
Non-breaking change which fixes an issue	[x] Yes [ ] No
Breaking change (fix or feature that would cause existing functionality to not work as expected)	[ ] Yes [x] No

Testing	Complete
I have added tests that prove my fix is effective or that my feature works	[x] Yes [ ] No
New and existing tests pass locally with my changes	[ ] Yes [x] No

Any additional collaborators for this PR?

Any Specific Reviewer approval needed?

aleish-m commented 1 year ago

Also, I noticed no new factory was created by the factorybot for either schema. Did factorybot not create the factories for you when you did your migrations??? We should get those factories set up...