PlanQK / planqk-platform

PlanQK Platform Issue Repository
3 stars 0 forks source link

Provide the same entity attributes for Pub/Sub topics with events "CREATED" and "MODIFIED" #54

Closed darya-mart closed 3 years ago

darya-mart commented 3 years ago

Priority: low (as a short term solution we serialize nulls by fetching the topic).

When user creates an algorithm using the plattform content the topic with event type "CREATED" and following (example) algorithm attributes is published: { "id": "15e364ca-cca3-47cb-af25-8e6a1414fcde", "name": "TestAlgorithm", "nisqReady": false, "entityMaturity": "INITIAL", "publications": [], "requiredComputeResourceProperties": [], "sketches": [], "computationModel": "QUANTUM", "problemTypes": [], "applicationAreas": [], "tags": [], "implementations": [], "discussionTopics": [], "learningMethods": [], "algorithmRelations": [] }.

However, when user modifies algorithm, e.g. add intent, the field "intent" is added to the algorithm attributes and is sended in the topic "MODIFIED": { "id": "15e364ca-cca3-47cb-af25-8e6a1414fcde", "name": "TestAlgorithm", "nisqReady": false, "entityMaturity": "INITIAL", "publications": [], "intent": "test intent" "requiredComputeResourceProperties": [], "sketches": [], "computationModel": "QUANTUM", "problemTypes": [], "applicationAreas": [], "tags": [], "implementations": [], "discussionTopics": [], "learningMethods": [], "algorithmRelations": [] }.

Suggestion Since we hava a model for mapping, please provide all attributes a fully described algorithm can have (both in "created" and "modified" topics) with nullvalues if the fields are empty (similar to database dump).

However, since we define a models for each entity, we can also serialize nulls by fetching such as by mapping fields that are missed in the body are setted to null. But I think it would be more consistent we it comes directly from the topic. In this way we can also control that our models are compatible.

radufalcusanStoneone commented 3 years ago

Issue wurde gefixt