PlanQK / workflow-modeler

Modeler for quantum workflows
Apache License 2.0
3 stars 4 forks source link

Implement subprocess expansion if deployment model is too big #114

Closed wiomoc closed 6 months ago

wiomoc commented 8 months ago

ref: #31

LaviniaStiliadou commented 8 months ago

Seems not to work for me. Subprocess

If I reload the topology, the edges are there but the subprocess is not expanded Subprocess2

KuhnMn commented 8 months ago

I added a small improvement for the Smart Edges here. I noticed that the sorting by y only meant that edges coming from or going to the bottom or top still overlapped a lot, the example topology I had was barely decipherable, so I adjusted it. Might be better to move this to a different PR though or remove it if unwanted.

wederbn commented 8 months ago

Expanding the deployment model looks good in general, however, the margins are a bit too large:

image

Collapsing the deployment models leaves the subprocesses in the state with the expanded size:

image

LaviniaStiliadou commented 8 months ago

I think that the current implementation does not consider a change of the deployment model. For example if I change the CSAR (where the deployment model is bigger) then the subprocess does not change size. change-deployment-model

LaviniaStiliadou commented 8 months ago

I think the margins are not right when explanding the deployment model. The topology nodes are outside the subprocess topology-outside-subprocess

LaviniaStiliadou commented 7 months ago

no-csar If the option: "No CSAR" is selected, the size of the subprocess does not change back.

wederbn commented 6 months ago

Closed, as the edges are currently not smart enough and lead to overlaps