Closed KuhnMn closed 10 months ago
There are some issues regarding this PR:
I get the following error message when clicking on the "Artifact Wizard" Button multiple times:
Warning: You are calling ReactDOMClient.createRoot() on a container that has already been passed to createRoot() before. Instead, call root.render() on the existing root instead if you want to update it.
Possible solution:
Also rename the wizardDiv to something meaningful. Imagine adding new modals to the properties panel then no one would understand what wizardDiv is
Add a hover effect for the Artifact Wizard Button
Change the layout for Artifact Wizard Button so it looks similar to the other buttons. For example the border is too thick, the current font size is 15px but we use 13px in the properties panel
Rename Artifact Wizard to Upload Artifact
Rename OpenTosca to OpenTOSCA
Rename Show deployment to Show Deployment
Rename Hide deployment to Hide Deployment
The icon for OpenTOSCA is misleading. I suggest using the following icon
The icons for the first subbuttons of the OpenTOSCA Plugin are identical. I suggest using the following icons: show, hide
Also, I am missing some docs. Regarding the new functionality show/hide deployment, the new icon ...
QuantumWorkflowModeler: modal-container is not really a meaningful name, imagine having multiple modals
Using the createRoot
technic, they all can use the same container
Warning: Each child in a list should have a unique "key" prop. Check the render method of `ArtifactUploadModal`.
This PR includes the extraction of the deployment functionality into its own plugin, an extended Dockerfile, as well as an initial button and window for attaching deployment artifacts to service tasks.