Fix POPF error with empty problem

PlanSys2 / ros2_planning_system

This repo contains a PDDL-based planning system for ROS2.

Apache License 2.0

396 stars 87 forks source link

Fix POPF error with empty problem #302

Closed Butakus closed 8 months ago

Butakus commented 8 months ago

We found that, in some cases, POPF segfaults when the problem definition does not include the :objects, :init and :goal sections. That caused the domain_expert to report a "PDDL syntax error" message and crash. The issue happens when checking if a domain is valid, because an empty problem is auto-generated and passed to POPF.

This PR should fix this issue.

fmrico commented 8 months ago

Hi @Butakus

CI is failing. It is strange because I know this resolves the "PDDL syntax error" error, but there is something strange with popf. We need to dig more into this problem.

I will close this PR now, but it is still helpful for documenting this and user could patch this problem.

Best