search

Planeshifter / node-Rstats

[UNMAINTAINED] An interface for node.js to statistical programming language R based on the fabulous Rcpp package
GNU General Public License v2.0
58 stars 16 forks source link

Update to Nan 2.x / NodeJS 4.x interface #12

Closed ijsf closed 8 years ago

ijsf commented 8 years ago

The current version of rstats doesn't seem to be compatible with Nan 2.x / NodeJS 4.x. I've done a minor refactoring of the code to solve this issue.

The npm test runs successfully and rstats seems to be working with these changes on iojs 3.x as well.

Planeshifter commented 8 years ago

Thanks for taking the initiative and updating the code! It seems that the new version of nan has breaking changes, so the package won't work anymore for node versions prior to 4.0.0. I am a bit hesitant to merge your request because of this; I am wondering if there is an easy way to support both 4.0.0 and earlier versions of node?

ijsf commented 8 years ago

Thanks, not sure about the backwards compatibility.

In any case, I'll keep my fork up-to-date with the latest NodeJS, or more specifically io.js, as we intend on using this module in a bigger project :)

It is therefore likely that I'll be doing more patches.

Planeshifter commented 8 years ago

Awesome, glad to see you are making progress! I think we should merge your changes and dump compatibility for older node versions. People running older node versions still can install the older versions of the package and I have not been making any updates either, so after reflection this does seem to be that big of an issue. Will do so over the weekend.