Planet-NULLCAST / curriculum

Free curriculum platform - for devs who like to learn web development!

https://nullcast.dev

22 stars 35 forks source link

fix: added validation #794

Closed kunwar-11 closed 2 years ago

kunwar-11 commented 2 years ago

Pull Request Template

Description

added validation in login page email field

Fixes #313

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

thealpha93 commented 2 years ago

The issue says there's a similar bug in the full name field in the signup page too @kunwar-11

kunwar-11 commented 2 years ago

The issue says there's a similar bug in the full name field in the signup page too @kunwar-11

it's working fine in sign up page