PlanetHunters / tkmatrix

Transits Inject and Recovery Multi-phase Analysis
MIT License
6 stars 1 forks source link

error when using tkmatrix for star with radius > 1 solar radius #29

Closed toribonidie closed 1 year ago

toribonidie commented 1 year ago

Hi!

Sorry to bother you again, but I am wondering if tkmatrix is compatible with stars greater than 1 solar radius. I was hoping to use this to do transit injection and recovery for planets around red clump stars, but I get the error: ValueError: radius_1 argument out of range . I looked into the lc.py file in ellc, and it looks like it raises an error any time the star has a radius greater than 1.

Have you tried using tkmatrix for stars with radii greater than 1? If not, I would suggest adding this to the readme!

Thanks so much.

martindevora commented 1 year ago

can you share the properties.yaml file you are using? That'd help to reproduce it. I will give it a try in the meantime with any other properties I can come with as I never tried R > 1R_sun.

martindevora commented 1 year ago

Also, can you share the entire traceback of the exception?

martindevora commented 1 year ago

BTW: The code in ellc does this:

  if (radius_1 <= 0) or (radius_1 > 1):
    raise ValueError("radius_1 argument out of range")

but in ellc the star radius is given in in units of the semi-major axis of the system. That is, R_star.to_au / semi_major_axis. The semi_major_axis depends on the star mass and the planet period. So it might be that the star radius is greater than the distance to the planet (radius_1 > 1), which would mean that the planet could not exist.

What was your minimum period in the properties.yaml ? Please share it to have a further look.

Regards.

toribonidie commented 1 year ago

Hi!

Thank you again for such a quick response. I think that the period does seem to be the issue, and it looks like I picked a weird system to start with. I am looking at TIC 15932677, a red clump star with a potential planet transiting every 1.4 days. So I let my period range go down to 1 day and masked the planet candidate (file attached). However, if this star actually has the radius predicted by lightkurve (10.8 Rsun) , this system does not even seem possible. I am attaching the .yaml file and traceback but I think you're right and I should just pick another star and pick a different minimum period. Not sure what is going on with this system.

Thanks again for the help nohup.out.txt TIC15932677.yaml.txt

martindevora commented 1 year ago

First of all:

Second, I've tried your target with the pipeline that we develop together in the Granada and LIège Universities: https://github.com/franpoz/SHERLOCK. The results show:

I have no explanation about the star radius, but it seems that there are other measurements from other users in ExoFop that substantially differ from the 10.8 M_sun.

toribonidie commented 1 year ago

Thank you so much, this is very helpful!

martindevora commented 1 year ago

Hello, good morning. I just found out the reason causing all NaNs. It seems that the MAST is not providing limb darkening coefficients, hence ellc is not able to return anything. You can inject them in the MATRIX properties like this:

TARGET: "TIC 15932677"
SECTORS: [44]
EXPOSURE_TIME: 120
MIN_PERIOD: 1.4 # I saw that this is approximately the first period where the planet would not be inside the star radius
MAX_PERIOD: 30
STEPS_PERIOD: 10
MIN_RADIUS: 2
MAX_RADIUS: 3.5
STEPS_RADIUS: 10
PHASES: 1
DETREND_WS: 1.0 # I changed this becase 0.5 days is a small detrending window size for such a big star, where the transits might take even 1 day long for medium periods.
CPUS: 40
KNOWN_TRANSITS:
  - P: 1.436896
    D: 0.098625
    T0: 2500.871
OVERSAMPLING: 1
STAR:
  "TIC 15932677":
    MASS: 10.0
    MASS_LOWER_ERROR: 0.5
    MASS_UPPER_ERROR: 0.5
    RADIUS: 10.85
    RADIUS_LOWER_ERROR: 0.2
    RADIUS_UPPER_ERROR: 0.2
    TEFF: 4876
    LD_COEFFICIENTS: [0.25, 0.64] # Replace with your common values for red giants

And then MATRIX will have some models to run!

NOTE: I will make MATRIX to exit if there are no limb-darkening parameters in the next version, as they seem to be required by ellc. NOTE 1: Don't know if you already noticed, but this star was also observed in the K2 mission (SHERLOCK told me that).

martindevora commented 1 year ago

Hello again,

I've already published a new MATRIX version that:

toribonidie commented 1 year ago

Thank you so much for all of your help! I was able to run it successfully on TIC 15932677 and a couple other red clump stars. If there is anything I can do to help going forward, please reach out!

martindevora commented 1 year ago

Thank you. I hope it helps with your research. Regards.