Planimeter / game-engine-2d

Planimeter Game Engine 2D - LÖVE-based game engine for Lua
https://github.com/Planimeter/game-engine-2d/wiki
MIT License
736 stars 74 forks source link

Moved onPlayerChat hook call from say to onChatReceived #54

Closed uen closed 9 years ago

uen commented 9 years ago

First I thought onPlayerChat was meant to be called only when you sent a message, but then I saw the speech bubble thingies use that hook (meaning the speech bubbles only work when you talk - doubt this is intentional)

Moving the call to onChatReceived means you'll only see the message when the server actually gets it (so the server can block messages ect) and onPlayerChat will be called when anybody sends a message (which also fixed speech bubbles)

andrewmcwatters commented 9 years ago

Nice catch, thanks! Sorry I let that slip through. :x

andrewmcwatters commented 9 years ago

Pending upstream merge to vertex-adventure.

andrewmcwatters commented 9 years ago

Merged to vertex-adventure upstream.