search

Planimeter / game-engine-2d

Planimeter Game Engine 2D - LÖVE-based game engine for Lua
https://github.com/Planimeter/game-engine-2d/wiki
MIT License
736 stars 74 forks source link

Error on Start when Fullscreen is enabled #80

Closed BratwurstMitSenf closed 7 years ago

BratwurstMitSenf commented 7 years ago

When Fullscreen is enabled in the Settings, the following error is thrown at startup: err

It seems that the clientwindow is started up in windowed and then resized to fullscreen before the framebuffer is initialized, leading to the nullreference exception inside the eventhandler.

I didn't have time to dive into it yet, since i just found it today during lunchbreak. I'll try to find a fix this weekend and send a patch.

Otherwise thank's for this fine piece of software. I'm very impressed so far. :wink:

andrewmcwatters commented 7 years ago

Hey, thanks for reporting this issue! Just curious, since we're in the middle of this engine-wide refactor, was this in master/v8.0.0?

I have some patches upstream from our flagship game, which uses Grid, and I should be able to merge this back to grid-sdk.

andrewmcwatters commented 7 years ago

I'm guessing this must be from the latest, since it's from the client handlers script.

BratwurstMitSenf commented 7 years ago

I just downloaded the latest 8.0.0 Pre Release from the Releases-Page. But once I get home, I can give it a quick try with the sources from the master-branch.

andrewmcwatters commented 7 years ago

Cool, should be roughly the same. I'll work on this tonight after work. Super appreciative about the report, thanks!

BratwurstMitSenf commented 7 years ago

No problem :smile:

andrewmcwatters commented 7 years ago

This issue has been obsoleted. Please see https://gitter.im/Planimeter/grid-sdk